PR #20332: [ds-fusion] Add runtime support for host calculation of offsets in ds fusion #22576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_725575581
branch
3 times, most recently
from
97857af to
e27b97d
Compare
…fsets in ds fusion Imported from GitHub PR #20332 This patch adds the support for calculating offset on the host at runtime when the offset depends on the loop induction variable. This is done by extracting the offset computation, the induction variable initialization and the induction variable update as independent computations and they are evaluated on the host at runtime. This avoids device-to-host copy for this fusion in these cases. Copybara import of the project: -- 5c85fe7 by Shraiysh Vaishay <[email protected]>: Add runtime support for host calculation of offsets in ds fusion This patch adds the support for calculating offset on the host at runtime when the offset depends on the loop induction variable. This is done by extracting the offset computation, the induction variable initialization and the induction variable update as independent computations and they are evaluated on the host at runtime. This avoids device-to-host copy for this fusion in these cases. -- b5573b0 by Shraiysh Vaishay <[email protected]>: Addressed comments -- decde73 by Shraiysh Vaishay <[email protected]>: Rebase -- f98d9dc by Shraiysh Vaishay <[email protected]>: Rebase Merging this change closes #20332 COPYBARA_INTEGRATE_REVIEW=#20332 from shraiysh:ds_fusion_3 f98d9dc PiperOrigin-RevId: 726440397
copybara-service
bot
force-pushed
the
test_725575581
branch
from
e27b97d to
988e55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #20332: [ds-fusion] Add runtime support for host calculation of offsets in ds fusion
Imported from GitHub PR #20332
This patch adds the support for calculating offset on the host at runtime when the offset depends on the loop induction variable. This is done by extracting the offset computation, the induction variable initialization and the induction variable update as independent computations and they are evaluated on the host at runtime. This avoids device-to-host copy for this fusion in these cases.
Copybara import of the project:
--
5c85fe7 by Shraiysh Vaishay [email protected]:
Add runtime support for host calculation of offsets in ds fusion
This patch adds the support for calculating offset on the host at
runtime when the offset depends on the loop induction variable. This is
done by extracting the offset computation, the induction variable
initialization and the induction variable update as independent
computations and they are evaluated on the host at runtime. This avoids
device-to-host copy for this fusion in these cases.
--
b5573b0 by Shraiysh Vaishay [email protected]:
Addressed comments
--
decde73 by Shraiysh Vaishay [email protected]:
Rebase
--
f98d9dc by Shraiysh Vaishay [email protected]:
Rebase
Merging this change closes #20332
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20332 from shraiysh:ds_fusion_3 f98d9dc