Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR #22572: Fix build break in convolution_thunk_internal
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 726463713
- Loading branch information