Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test structured bindings #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −12
Open

test structured bindings #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions shardy/dialect/sdy/transforms/propagation/basic_propagation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,7 @@ LogicalResult BasicPropagationPassImpl::propagate(
conservativePropagation, shardingGroupMap);
// We only need a single iteration (and another to confirm convergence), since
// we make sure ops whose sharding changes are added back to the worklist.
GreedyRewriteConfig config;
config.useTopDownTraversal = true;
config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled;
config.fold = false;
config.cseConstants = false;
GreedyRewriteConfig config{.useTopDownTraversal = true};
if (failed(applyPatternsGreedily(moduleOp, std::move(patterns), config))) {
// We should always converge in 2 iterations, if we don't, something is
// wrong.
Expand All @@ -628,8 +624,8 @@ LogicalResult BasicPropagationPassImpl::propagate(
return failure();
}

// Pushes any shardings from the values returned in the terminator of the body
// of `funcOp` to the corresponding `funcOp` result type attrs.
// Pushes any shardings from tha values returned in the terminator of the body
// of `funcOp` to the coresponding `funcOp` result type attrs.
if (failed(propagateFuncResults(moduleOp, symbolTable, factorPropagation,
shardingGroupMap))) {
return failure();
Expand Down
12 changes: 7 additions & 5 deletions shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void saveShardingOriginsOnModule(

func::FuncOp funcOp = getEnclosingOfType<func::FuncOp>(owningOp);

// TODO(bartchr): Swap the map to store `ValueOrFuncResult` to avoid having
// TODO(bartchr): Swop the map to sture `ValueOrFuncResult` to avoid having
// to do this terminator finding logic just to set the func result attr.
OpOperand* terminatorOperand = getTerminatorOperand(value, funcOp);

Expand All @@ -317,10 +317,12 @@ void saveShardingOriginsOnModule(
builder.getDictionaryAttr(entries));
}
TypeSwitch<Operation*, void>(owningOp)
.Case<func::FuncOp>([&, value = value](func::FuncOp funcOp) {
funcOp.setArgAttr(cast<BlockArgument>(value).getArgNumber(),
kShardingOriginsAttr,
builder.getDictionaryAttr(entries));
.Case<func::FuncOp>([&](func::FuncOp funcOp) {
if (value) {
funcOp.setArgAttr(cast<BlockArgument>(value).getArgNumber(),
kShardingOriginsAttr,
builder.getDictionaryAttr(entries));
}
})
.Case<ShardingConstraintOp, DataFlowEdgeOp>([&](Operation* op) {
op->setAttr(kShardingOriginsAttr, builder.getDictionaryAttr(entries));
Expand Down