Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0 fr1 rsyslog image #439

Conversation

gthiemonge
Copy link
Contributor

@gthiemonge gthiemonge commented Jan 30, 2025

JIRA: OSPRH-13530
JIRA: OSPRH-12496

beagles and others added 2 commits January 30, 2025 08:54
The RELATED_IMAGE_OCTAVIA_RSYSLOG_IMAGE_URL_DEFAULT and related default
overrides were missing for the log offloading feature.

JIRA: OSPRH-12496
The rsyslog init container image used directly an upstream image hostsed
on quay, but it should rather use the override from the env var when
available.

JIRA: OSPRH-13530
@openshift-ci openshift-ci bot requested review from gibizer and karelyatin January 30, 2025 07:59
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gthiemonge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gthiemonge
Copy link
Contributor Author

/test octavia-operator-build-deploy-kuttl

Copy link
Collaborator

@beagles beagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8746b87 into openstack-k8s-operators:18.0-fr1 Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants