Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45469, OCPBUGS-49337: [DownstreamMerge] 2-6-25 #2441

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

qinqon and others added 10 commits February 4, 2025 18:13
After live migration the IPv4 gateway mac cache at VMs is pointing to
the previous node.

This change add a function to update that sending at GARP over the
management port with the VM's new node gateway mac.

Also create a new `BroadcastGARP` util helper to send GARPs also adapt the part of
ovn-kuberntes that send them.

Signed-off-by: Enrique Llorente <[email protected]>
Add a check to ensure that ipv4 mac address is propertly changes after
live migration.

Signed-off-by: Enrique Llorente <[email protected]>
…e-ipv4-gateway-live-migration

kubevirt, l2, pudn: reconcile ipv4 gateway mac after live migration
When configuring LSP with disabled the OVN L2 lookup table still
contains an entry with the mac but with action "drop", removing also the
address remove that entry from the table so localnet traffic can be
correctly live migrated.

Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
…igration

kubevirt, localnet: Reduce live migration downtime.
@qinqon qinqon changed the title Merge 2 6 25 [DownstreamMerge] 2-6-25 Feb 6, 2025
@openshift-ci openshift-ci bot requested review from trozet and tssurya February 6, 2025 06:39
@qinqon qinqon changed the title [DownstreamMerge] 2-6-25 OCPBUGS-48337: [DownstreamMerge] 2-6-25 Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2025
@openshift-ci-robot
Copy link
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-48337, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Merge to include virt last importanat bits for UDN:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon qinqon changed the title OCPBUGS-48337: [DownstreamMerge] 2-6-25 OCPBUGS-45469, OCPBUGS-48337: [DownstreamMerge] 2-6-25 Feb 6, 2025
@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Feb 6, 2025
@openshift-ci-robot
Copy link
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-48337, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Merge to include virt last importanat bits for UDN:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references Jira Issue OCPBUGS-48337, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon qinqon changed the title OCPBUGS-45469, OCPBUGS-48337: [DownstreamMerge] 2-6-25 OCPBUGS-45469, OCPBUGS-49337: [DownstreamMerge] 2-6-25 Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 6, 2025
@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 6, 2025
@openshift-ci-robot
Copy link
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-49337, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Merge to include virt last importanat bits for UDN:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references Jira Issue OCPBUGS-49337, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

We don't have a virt non TP yet, let's run TP to run those tests.

/test e2e-aws-ovn-virt-techpreview

UPDATE: PR with with pre-submits for non TP -> openshift/release#61320

@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/payload 4.19 ci blocking
/payload 4.19 nightly blocking

Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@qinqon: trigger 4 job(s) of type blocking for the ci release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9d13700-e472-11ef-97da-69e65895c782-0

trigger 14 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance
  • periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9d13700-e472-11ef-97da-69e65895c782-1

@tssurya
Copy link
Contributor

tssurya commented Feb 6, 2025

/retest-required

3 similar comments
@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/retest-required

@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/retest-required

@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/retest-required

@jluhrsen
Copy link
Contributor

jluhrsen commented Feb 6, 2025

/test e2e-metal-ipi-ovn-ipv6-techpreview
/test e2e-aws-ovn-hypershift-conformance-techpreview
/test e2e-azure-ovn-techpreview
/test e2e-metal-ipi-ovn-dualstack-techpreview
/test e2e-vsphere-ovn-techpreview
/test e2e-aws-ovn-techpreview
/test e2e-gcp-ovn-techpreview
/test e2e-metal-ipi-ovn-techpreview
/test openshift-e2e-gcp-ovn-techpreview-upgrade
/test e2e-aws-ovn-virt-techpreview

@tssurya
Copy link
Contributor

tssurya commented Feb 6, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 6, 2025
@qinqon
Copy link
Contributor Author

qinqon commented Feb 6, 2025

/retest-required

@jluhrsen
Copy link
Contributor

jluhrsen commented Feb 6, 2025

payload jobs looked pretty good

I know we probably aren't too worried about techpreview jobs anymore since UDN is GA and enabling techpreview can bring in other unstable things to the job, but I did check all of those that failed. two of them had some network-y test case failure, but both seemed like an issue with etc (according to test output). just fyi.

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2441/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-techpreview/1887536901812916224
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2441/pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-ovn-techpreview/1887536902114906112

@trozet
Copy link
Contributor

trozet commented Feb 6, 2025

/lgtm

@trozet
Copy link
Contributor

trozet commented Feb 6, 2025

@qinqon dont we need a virt job (non tech preview) running in our repo so that we make sure virt continues to work with UDN and persistent IP? maybe you can work with @jluhrsen to enable that

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b79a62c and 2 for PR HEAD e57f451 in total

@qinqon
Copy link
Contributor Author

qinqon commented Feb 7, 2025

/retest-requied

@qinqon
Copy link
Contributor Author

qinqon commented Feb 7, 2025

/retest-required

@qinqon
Copy link
Contributor Author

qinqon commented Feb 7, 2025

@qinqon dont we need a virt job (non tech preview) running in our repo so that we make sure virt continues to work with UDN and persistent IP? maybe you can work with @jluhrsen to enable that

@trozet these are the pre-submit non TP jobs -> openshift/release#61320 @jluhrsen can you take a look ?

Also we have run the tech preview job and it looks ok -> https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2441/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-virt-techpreview/1887536901850664960

@qinqon
Copy link
Contributor Author

qinqon commented Feb 7, 2025

/retest-required

@qinqon
Copy link
Contributor Author

qinqon commented Feb 7, 2025

/retest-required

@jluhrsen I don't think the failing jobs are related to this.

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview e57f451 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv4-bgp-techpreview e57f451 link false /test e2e-metal-ipi-ovn-ipv4-bgp-techpreview
ci/prow/e2e-azure-ovn e57f451 link false /test e2e-azure-ovn
ci/prow/e2e-openstack-ovn e57f451 link false /test e2e-openstack-ovn
ci/prow/security e57f451 link false /test security
ci/prow/e2e-ovn-hybrid-step-registry e57f451 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-single-node-techpreview e57f451 link false /test e2e-aws-ovn-single-node-techpreview
ci/prow/e2e-aws-ovn-techpreview e57f451 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-vsphere-ovn-techpreview e57f451 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack-techpreview e57f451 link false /test e2e-metal-ipi-ovn-dualstack-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview e57f451 link false /test e2e-metal-ipi-ovn-ipv6-techpreview
ci/prow/e2e-aws-ovn-virt-techpreview e57f451 link false /test e2e-aws-ovn-virt-techpreview
ci/prow/e2e-azure-ovn-techpreview e57f451 link false /test e2e-azure-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 633ebb6 into openshift:master Feb 7, 2025
27 of 40 checks passed
@openshift-ci-robot
Copy link
Contributor

@qinqon: Jira Issue OCPBUGS-45469: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45469 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-49337: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49337 has been moved to the MODIFIED state.

In response to this:

Merge to include virt last importanat bits for UDN:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.19.0-202502071607.p0.g633ebb6.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.19.0-202502071607.p0.g633ebb6.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.19.0-202502071607.p0.g633ebb6.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants