-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45469, OCPBUGS-49337: [DownstreamMerge] 2-6-25 #2441
Conversation
After live migration the IPv4 gateway mac cache at VMs is pointing to the previous node. This change add a function to update that sending at GARP over the management port with the VM's new node gateway mac. Also create a new `BroadcastGARP` util helper to send GARPs also adapt the part of ovn-kuberntes that send them. Signed-off-by: Enrique Llorente <[email protected]>
Add a check to ensure that ipv4 mac address is propertly changes after live migration. Signed-off-by: Enrique Llorente <[email protected]>
…e-ipv4-gateway-live-migration kubevirt, l2, pudn: reconcile ipv4 gateway mac after live migration
Signed-off-by: Enrique Llorente <[email protected]>
When configuring LSP with disabled the OVN L2 lookup table still contains an entry with the mac but with action "drop", removing also the address remove that entry from the table so localnet traffic can be correctly live migrated. Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
…igration kubevirt, localnet: Reduce live migration downtime.
@qinqon: This pull request references Jira Issue OCPBUGS-48337, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-48337, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. This pull request references Jira Issue OCPBUGS-48337, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-49337, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@qinqon: This pull request references Jira Issue OCPBUGS-45469, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. This pull request references Jira Issue OCPBUGS-49337, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We don't have a virt non TP yet, let's run TP to run those tests. /test e2e-aws-ovn-virt-techpreview UPDATE: PR with with pre-submits for non TP -> openshift/release#61320 |
/payload 4.19 ci blocking |
@qinqon: trigger 4 job(s) of type blocking for the ci release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9d13700-e472-11ef-97da-69e65895c782-0 trigger 14 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9d13700-e472-11ef-97da-69e65895c782-1 |
/retest-required |
3 similar comments
/retest-required |
/retest-required |
/retest-required |
/test e2e-metal-ipi-ovn-ipv6-techpreview |
/label acknowledge-critical-fixes-only |
/retest-required |
payload jobs looked pretty good I know we probably aren't too worried about techpreview jobs anymore since UDN is GA and enabling techpreview can bring in other unstable things to the job, but I did check all of those that failed. two of them had some network-y test case failure, but both seemed like an issue with etc (according to test output). just fyi. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2441/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-techpreview/1887536901812916224 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-requied |
/retest-required |
@trozet these are the pre-submit non TP jobs -> openshift/release#61320 @jluhrsen can you take a look ? Also we have run the tech preview job and it looks ok -> https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2441/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-virt-techpreview/1887536901850664960 |
/retest-required |
/retest-required @jluhrsen I don't think the failing jobs are related to this. |
@qinqon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
633ebb6
into
openshift:master
@qinqon: Jira Issue OCPBUGS-45469: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-45469 has been moved to the MODIFIED state. Jira Issue OCPBUGS-49337: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-49337 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-base |
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-microshift |
[ART PR BUILD NOTIFIER] Distgit: ose-ovn-kubernetes |
Merge to include virt last importanat bits for UDN: