AUTH-8: Move usercache from the oauth-apiserver to lib-go #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
sttts
reviewed
Oct 12, 2021
|
|
||
| // ByUserIndexKeys is cache.IndexFunc for Groups that will index groups by User, so that a direct cache lookup | ||
| // using a User.Name will return all Groups that User is a member of | ||
| func ByUserIndexKeys(obj interface{}) ([]string, error) { |
There was a problem hiding this comment.
yes, it's needed to set up the indexer for the given informer: https://github.com/openshift/oauth-apiserver/blob/7423fd05978658842ca56236d315e28a4fa6d40a/pkg/oauth/apiserver/apiserver.go#L109-L114
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the usercache from the oauth-apiserver (https://github.com/openshift/oauth-apiserver/blob/7423fd05978658842ca56236d315e28a4fa6d40a/pkg/tokenvalidation/usercache/groups.go) to library-go so that it is reusable in the oauth-server group sync (openshift/oauth-server#87).
cc @openshift/openshift-team-auth-maintainers