Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to test openshift/docker-distribution/pull/44 #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PR to test openshift/docker-distribution/pull/44 #413

wants to merge 1 commit into from

Conversation

mpryc
Copy link

@mpryc mpryc commented Sep 26, 2024

This PR is for testing change proposed in the:
openshift/docker-distribution#44

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mpryc
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kaovilai
kaovilai reviewed Sep 26, 2024
View reviewed changes
kaovilai
kaovilai suggested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the hash.

@mpryc mpryc force-pushed the testing_distribution_pr_44 branch 2 times, most recently from a704553 to 04ae9a7 Compare September 27, 2024 12:36
kaovilai
kaovilai suggested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the repos where they use vendor directory.

Please run go mod vendor then push.

@mpryc
PR to test openshift/docker-distribution/pull/44
a12edd5 
This PR is for testing change proposed in the:
  openshift/docker-distribution#44

Signed-off-by: Michal Pryc <[email protected]>
@mpryc mpryc force-pushed the testing_distribution_pr_44 branch from 04ae9a7 to a12edd5 Compare September 30, 2024 11:58
@kaovilai
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

@mpryc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-image-registry a12edd5 link true /test e2e-agnostic-image-registry
ci/prow/unit a12edd5 link true /test unit
ci/prow/e2e-metal-ipi-ovn-ipv6 a12edd5 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-scos-images a12edd5 link true /test okd-scos-images
ci/prow/e2e-aws-ovn a12edd5 link true /test e2e-aws-ovn
ci/prow/e2e-aws-upgrade a12edd5 link true /test e2e-aws-upgrade
ci/prow/e2e-aws-image-registry a12edd5 link true /test e2e-aws-image-registry
ci/prow/images a12edd5 link true /test images
ci/prow/e2e-hypershift a12edd5 link true /test e2e-hypershift
ci/prow/verify a12edd5 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai requested changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpryc @kaovilai @openshift-bot @openshift-merge-robot