Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2120: Enable EnsureCustomLabels e2e test #5511

Merged
merged 1 commit into from
Feb 3, 2025
Merged

HOSTEDCP-2120: Enable EnsureCustomLabels e2e test #5511

merged 1 commit into from
Feb 3, 2025

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jan 30, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2025 •
edited by openshift-ci bot
Loading

@muraee: This pull request references HOSTEDCP-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Jan 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 30, 2025
@muraee muraee force-pushed the enabled-labels-e2e branch from ee44352 to 8637a94 Compare January 30, 2025 15:29
@muraee muraee changed the title HOSTEDCP-2120: EnsureCustomLabels: Enable EnsureCustomLabels e2e test HOSTEDCP-2120: Enable EnsureCustomLabels e2e test Jan 30, 2025
sjenning
sjenning requested changes Jan 30, 2025
View reviewed changes
test/e2e/create_cluster_test.go Outdated Show resolved Hide resolved
test/e2e/create_cluster_test.go Outdated Show resolved Hide resolved
@muraee muraee force-pushed the enabled-labels-e2e branch 3 times, most recently from f8ece26 to debd44c Compare January 31, 2025 13:47
@muraee muraee force-pushed the enabled-labels-e2e branch from debd44c to b467a84 Compare January 31, 2025 13:56
@muraee
Copy link
Contributor Author

muraee commented Jan 31, 2025

/retest-required

@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e11f0a6 and 2 for PR HEAD b467a84 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f3a5b0a and 1 for PR HEAD b467a84 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f3a5b0a and 2 for PR HEAD b467a84 in total

@muraee
Copy link
Contributor Author

muraee commented Feb 3, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025 •
edited
Loading

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b467a84 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f3a5b0a and 2 for PR HEAD b467a84 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e634469 into openshift:main Feb 3, 2025
13 of 14 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202502031606.p0.ge634469.assembly.stream.el9.
All builds following this will include this PR.

@muraee muraee mentioned this pull request Feb 4, 2025
Merged
@JoelSpeed JoelSpeed mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning sjenning requested changes

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muraee @openshift-ci-robot @sjenning @openshift-bot