change how cleanup works for audit container

[jared-hayes-dev]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jared-hayes-dev
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jared-hayes-dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	5101546	link	true	/test unit
ci/prow/e2e-aks	5101546	link	true	/test e2e-aks
ci/prow/e2e-kubevirt-aws-ovn-reduced	5101546	link	true	/test e2e-kubevirt-aws-ovn-reduced

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Joseph-Goergen]

@jared-hayes-dev Any particular reason why we explicitly exit here and all other places?

[Joseph-Goergen]

@jared-hayes-dev Any particular reason why we explicitly exit here and along the other places?

[Joseph-Goergen]

I believe the wait below holds while the "background" (the tail) process is running.

[jared-hayes-dev]

• I think it is good practice to be explicit once we handle sigterm for the completion of the script
• Although that wait does in fact handle that particular case (waiting for the last bg process) I think it is good practice to have a wait after killing all the child processes to ensure all bg processes are cleaned up before exiting.

[rtheis]

@jared-hayes-dev PR tests are failing in part because the test data files need to be updated based on this changes in this PR.

[rtheis]

Interestingly enough that fixing this bug cause other problems which we need to discuss since shutting down the audit logging too early blocks audit events from being sent during the shutdown process. We need to discuss an overall solution.