Disable leader election between ingress classes #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
reviewed
Apr 29, 2021
| ctx := signals.NewContext() | ||
|
|
||
| // Disable leader election to allow both ingress controllers to do their job. | ||
| // TODO: Fix the respective clash in Knative's reconciler framework. |
There was a problem hiding this comment.
do we track this somewhere upstream ? e.g. knaitve/pkg ?
There was a problem hiding this comment.
Yep knative/pkg#2109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now running two ingress reconcilers (one for Kourier and one for Istio) in the same component, which makes their respective leader election clash
As a result, only one of the reconcilers will run in practice, which breaks things horribly. We don't actually run multiple instances of these today anyway, so disabling the HA code fixes that situation.