#3030 Add flatten Command for Objects to PPL
#3267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currantw
changed the title
flatten Command for Objects to PPL
currantw
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
acarbonetto
reviewed
Jan 28, 2025
core/src/main/java/org/opensearch/sql/planner/physical/FlattenOperator.java
Outdated
Show resolved
Hide resolved
currantw
commented
Jan 28, 2025
ppl/src/test/java/org/opensearch/sql/ppl/parser/AstBuilderTest.java
Outdated
Show resolved
Hide resolved
ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java
Outdated
Show resolved
Hide resolved
currantw
commented
Jan 30, 2025
core/src/test/java/org/opensearch/sql/expression/ip/IPFunctionsTest.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/planner/DefaultImplementorTest.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
Jan 30, 2025
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
…eing preserved. Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
…at it also updates env, plus Javadoc formatting. Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
…ls`. Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
currantw
force-pushed
the
#3029_flatten_command
branch
from
4e6da8d to
6e176a3
Compare
acarbonetto
approved these changes
Feb 13, 2025
| @@ -277,7 +282,7 @@ public LogicalPlan visitRename(Rename node, AnalysisContext context) { | |||
| LogicalPlan child = node.getChild().get(0).accept(this, context); | |||
| ImmutableMap.Builder<ReferenceExpression, ReferenceExpression> renameMapBuilder = | |||
| new ImmutableMap.Builder<>(); | |||
| for (Map renameMap : node.getRenameList()) { | |||
| for (org.opensearch.sql.ast.expression.Map renameMap : node.getRenameList()) { | |||
There was a problem hiding this comment.
Why getRenameList returns a map? Shouldn't we rename it?
| @@ -448,6 +449,107 @@ public LogicalPlan visitEval(Eval node, AnalysisContext context) { | |||
| return new LogicalEval(child, expressionsBuilder.build()); | |||
| } | |||
|
|
|||
| /** | |||
| * Builds and returns a {@link org.opensearch.sql.planner.logical.LogicalFlatten} corresponding to | |||
There was a problem hiding this comment.
nit: You can add import and
Suggested change
| * Builds and returns a {@link org.opensearch.sql.planner.logical.LogicalFlatten} corresponding to | |
| * Builds and returns a {@link LogicalFlatten} corresponding to |
(and rerun spotlesssss)
Comment on lines
+473
to
+476
| * struct: { | ||
| * integer: 0, | ||
| * nested_struct: { string: "value" } | ||
| * }, |
There was a problem hiding this comment.
Isn't removing flattened struct? Why?
| if (!duplicateFieldNames.isEmpty()) { | ||
| throw new SemanticCheckException( | ||
| StringUtils.format( | ||
| "Flatten command cannot overwrite fields: %s", |
There was a problem hiding this comment.
Just to confirm that you have IT to cover that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: currantw [email protected]
Description
Implements
flattencommand for objects only.Out of scope
Does not implement flattening for arrays or aliasing. This will come in a follow-up PR.
Related Issues
Part of scope of #3030.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.