Add End-to-End tests to CI job #1043
Conversation
normanj-bitquill
requested review from
dai-chen,
mengweieric,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
Signed-off-by: Norman Jordan <[email protected]>
normanj-bitquill
force-pushed
the
e2e-ci
branch
from
8410d71 to
2352bc6
Compare
| } | ||
| } | ||
| }.start() | ||
| val completed = dockerProcess.waitFor(30, TimeUnit.MINUTES) |
There was a problem hiding this comment.
@normanj-bitquill why is the timeout so long ?
There was a problem hiding this comment.
I tested this in a different PR. It took about 13 minutes to startup the cluster. This includes downloading Docker images that are needed. 30 minutes is just to give a safe buffer around that.
There was a problem hiding this comment.
@YANG-DB This can be decreased but it we will want it to be 13 minutes plus a buffer. Could use 20 minutes instead.
There was a problem hiding this comment.
@normanj-bitquill is it possible to have a seperate workflow for e2e test? my concern is add e2e test will add 30mins for every PR.
Signed-off-by: Norman Jordan <[email protected]>
|
@LantaoJin @penghuo |
|
CI broken after this merge this PR. https://github.com/opensearch-project/opensearch-spark/commits/main/ @YANG-DB @normanj-bitquill should we revert this PR? |
|
@normanj-bitquill actually did find a real regression so IMO the feature is good to have... |
Description
Adds the End-to-End tests to the CI job GitHub action. They will be run with the integration tests. The end-to-end test results are included in the uploaded artifacts.
Related Issues
Related to #647
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.