End-to-End Async Query API PPL tests #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanj-bitquill
requested review from
dai-chen,
mengweieric,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
|
This PR also includes changes so that the |
YANG-DB
reviewed
Feb 6, 2025
There was a problem hiding this comment.
@normanj-bitquill can you please add javaDoc on the class & each method pupose ?
There was a problem hiding this comment.
I have added Javadoc comments.
YANG-DB
approved these changes
Feb 6, 2025
normanj-bitquill
force-pushed
the
e2e-async-ppl-tests
branch
from
d78ae92 to
75c3368
Compare
normanj-bitquill
force-pushed
the
e2e-async-ppl-tests
branch
from
75c3368 to
ec54bce
Compare
|
@YANG-DB This PR has been rebased off of main. |
|
@normanj-bitquill can you please check the failed CI ? |
* Some test are currently disabled due to #3298 Signed-off-by: Norman Jordan <[email protected]>
Signed-off-by: Norman Jordan <[email protected]>
normanj-bitquill
force-pushed
the
e2e-async-ppl-tests
branch
from
ec54bce to
7dfe631
Compare
|
@YANG-DB I rebased with the latest change in main. The CI ran successfully. |
penghuo
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Async Query PPL tests.
Related Issues
#1022
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.