#1020: earliest/latest not supported with where command
#1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
currantw
requested review from
dai-chen,
mengweieric,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
Signed-off-by: currantw <[email protected]>
currantw
commented
Jan 24, 2025
Comment on lines
+856
to
+857
| | EARLIEST | ||
| | LATEST |
There was a problem hiding this comment.
This is the only functional (non-test) change in this PR. Remainder of the changes are related to adding relative date time tests using where to integration and doc tests.
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
| | description | relative_string | | ||
| +--------------+-----------------+ | ||
| | Now | NOW | | ||
| | Tomorrow | +D@D | |
There was a problem hiding this comment.
+D will given a timestamp corresponding to the current time tomorrow, while +D@D will give a timestamp corresponding to the start of tomorrow (i.e. 00:00 AM).
YANG-DB
approved these changes
Jan 24, 2025
acarbonetto
approved these changes
Jan 24, 2025
|
Thanks @currantw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for using
earliestandlatestrelative time functions with thewherecommand.Related Issues
Resolved #1020.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.