Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exclusive type to Optional typing #582

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

gaiksaya
Copy link
Member

Description

After thorough debugging, as to why the groovy tests were hanging in build-repo (atleast in local), looks like class loading was the issue. Even though both classes ReleaseMetricsData and ReleaseCandidateStatus do not depend on each other in anyway, specifying explicit type OpenSearchMetricsQuery in field declarations was causing the issue.

Changed it to def which just treats it as a generic Object.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (12efe78) to head (25dcf63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #582   +/-   ##
=========================================
  Coverage     84.61%   84.61%           
  Complexity      133      133           
=========================================
  Files           123      123           
  Lines           780      780           
  Branches         86       86           
=========================================
  Hits            660      660           
  Misses           33       33           
  Partials         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaiksaya gaiksaya merged commit 9ad1886 into opensearch-project:main Feb 17, 2025
9 checks passed
@gaiksaya gaiksaya deleted the refactor-classes branch February 17, 2025 19:18
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 17, 2025
Signed-off-by: Sayali Gaikawad <[email protected]>
(cherry picked from commit 9ad1886)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants