Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bwc version dynamically #987

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

Hailong-am
Copy link
Collaborator

Description

remove hardcoded bwc version and replace it with fetching latest value from OpenSearch core

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <[email protected]>
@yuye-aws
Copy link
Member

yuye-aws commented Dec 2, 2024

Rerunning the CI checks now

@Hailong-am
Copy link
Collaborator Author

Hailong-am commented Dec 2, 2024

checking on and trying suggestion in opensearch-project/opensearch-build#5178

/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am
Copy link
Collaborator Author

verified get version function in CI, it works as expected.

> Configure project :notifications
Extracted latest 2.x version: 2.19.0
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.10.2
  OS Info               : Linux 6.5.0-10[25](https://github.com/opensearch-project/notifications/actions/runs/12113884869/job/33769553622?pr=987#step:6:26)-azure (amd64)
  JDK Version           : 21 (Eclipse Temurin JDK)
  JAVA_HOME             : /__t/Java_Temurin-Hotspot_jdk/21.0.5-11.0.LTS/x64
  Random Testing Seed   : F1A921C6D75F[27](https://github.com/opensearch-project/notifications/actions/runs/12113884869/job/33769553622?pr=987#step:6:28)CE
  In FIPS 140 mode      : false
=======================================

@amsiglan amsiglan merged commit da61023 into opensearch-project:main Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants