Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-place SSL certs hot reload documentation #9103

Merged

Conversation

willyborankin
Copy link
Contributor

@willyborankin willyborankin commented Jan 22, 2025

Description

Added in-place SSL certs hot reload documentation for the issue #opensearch-project/security#4427.

Issues Resolved

Closes #[insert issue number]

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@willyborankin willyborankin force-pushed the ssl-certs-hot-reload branch 2 times, most recently from 0311b99 to b0e6a5b Compare January 22, 2025 18:06
@Naarcha-AWS Naarcha-AWS added release-notes PR: Include this PR in the automated release notes v2.19.0 labels Jan 29, 2025
@Naarcha-AWS
Copy link
Collaborator

@cwperks or @stephen-crawford: Can one of you look over this PR for technical accuracy?

@Naarcha-AWS Naarcha-AWS added the 3 - Tech review PR: Tech review in progress label Jan 29, 2025
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. Left 2 minor comments.

_security/configuration/tls.md Outdated Show resolved Hide resolved

### Using the Reload Certificates API

Add the following to enable hot reloading using the Reload Certificates API:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the Reload Certificates API documentation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks: Documentation doesn't exist for this API beyond what's on this page, https://opensearch.org/docs/latest/security/configuration/tls/#hot-reloading-tls-certificates. I made an issue to track progress on creating that page. #9147

Naarcha-AWS and others added 2 commits February 3, 2025 09:55
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Feb 3, 2025
Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Feb 3, 2025
@Naarcha-AWS
Copy link
Collaborator

@natebower: This is ready for editorial review.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS @willyborankin Please see my comments and changes and let me know if you have any questions. Thanks!

_security/configuration/tls.md Outdated Show resolved Hide resolved
_security/configuration/tls.md Outdated Show resolved Hide resolved
_security/configuration/tls.md Outdated Show resolved Hide resolved
_security/configuration/tls.md Outdated Show resolved Hide resolved
```json
curl --cacert <ca.pem> --cert <admin.pem> --key <admin.key> -XPUT https://localhost:9200/_plugins/_security/api/ssl/transport/reloadcerts
```
{% include copy.html %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a copy as cURL button?

_security/configuration/tls.md Outdated Show resolved Hide resolved
```json
curl --cacert <ca.pem> --cert <admin.pem> --key <admin.key> -XPUT https://localhost:9200/_plugins/_security/api/ssl/http/reloadcerts
```
{% include copy.html %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a copy as cURL button?

Naarcha-AWS and others added 2 commits February 3, 2025 15:25
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit 166849d into opensearch-project:main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants