[BUG] Updated cache for the sub tree in Workbench #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
changed the title
mengweieric
reviewed
Feb 12, 2025
| const getMappings = ( | ||
| index: string, | ||
| dataSourceMDSId?: string | ||
| ): Promise<OpenSearchDashboardsResponse> | undefined => { |
There was a problem hiding this comment.
return Promise or undefined? is it supposed to be Promise<OpenSearchDashboardsResponse | undefined>?
|
does query workbench depend on this change? Why query workbench changes need to modify Observability? Could you elaborate more in description? |
|
so the workbench side tree in case of flint depends on the caching mechanism from observability thats why this PR has been added to update a few conditions in the caching |
|
may need to update snapshots: 19 snapshots failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Side tree flyout fix for the caching mechanism
Screen.Recording.2025-02-12.at.3.04.25.PM.mov
Issues Resolved
opensearch-project/dashboards-query-workbench#445
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.