Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main branch for 3.0.0.0-alpha1 / gradle 8.10.2 / JDK23 #698

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

andrross
Copy link
Member

@andrross andrross commented Jan 29, 2025

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

Part of #318

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon changed the title Update main branch for 3.0.0-alpha1 Update main branch for 3.0.0.0-alpha1 / gradle 8.10.2 / JDK23 Feb 13, 2025
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member

JDK21 is fine, probably need to update a few libs for jdk23.

@peterzhuamazon
Copy link
Member

Very confused what is happening as jdk23 also success on my local env.

@peterzhuamazon
Copy link
Member

Seems like OOM


> Task :integTest
java.lang.OutOfMemoryError: Java heap space
Dumping heap to /__w/asynchronous-search/asynchronous-search/build/heapdump/java_pid3224.hprof ...
Heap dump file created [26885188 bytes in 0.124 secs]


REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.testAsynchronousSearchIdParsingFailure" -Dtests.seed=5EA2FE4F0EA839C0 -Dtests.security.manager=false -Dtests.locale=bho -Dtests.timezone=America/Argentina/Salta -Druntime.java=23


> Task :test
Suite: Test class org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests

AsynchronousSearchIdTests > testAsynchronousSearchIdParsingFailure FAILED
  2> REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.testAsynchronousSearchIdParsingFailure" -Dtests.seed=5EA2FE4F0EA839C0 -Dtests.security.manager=false -Dtests.locale=bho -Dtests.timezone=America/Argentina/Salta -Druntime.java=23
    junit.framework.AssertionFailedError: Unexpected exception type, expected IllegalArgumentException but got java.lang.OutOfMemoryError: Java heap space
  2> junit.framework.AssertionFailedError: Unexpected exception type, expected IllegalArgumentException but got java.lang.OutOfMemoryError: Java heap space
        at __randomizedtesting.SeedInfo.seed([5EA2FE4F0EA839C0:DDB30DF5F32B874B]:0)
        at __randomizedtesting.SeedInfo.seed([5EA2FE4F0EA839C0:DDB30DF5F32B874B]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2894)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2875)
        at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.testAsynchronousSearchIdParsingFailure(AsynchronousSearchIdTests.java:36)

        Caused by:
        java.lang.OutOfMemoryError: Java heap space
            at org.apache.lucene.store.DataInput.readString(DataInput.java:225)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdConverter.parseAsyncId(AsynchronousSearchIdConverter.java:49)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.lambda$testAsynchronousSearchIdParsingFailure$0(AsynchronousSearchIdTests.java:36)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests$$Lambda/0x00007f8a934091b8.run(Unknown Source)
            at org.apache.lucene.tests.util.LuceneTestCase._expectThrows(LuceneTestCase.java:3044)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2894)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2875)
        at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.testAsynchronousSearchIdParsingFailure(AsynchronousSearchIdTests.java:36)

        Caused by:
        java.lang.OutOfMemoryError: Java heap space
            at org.apache.lucene.store.DataInput.readString(DataInput.java:225)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdConverter.parseAsyncId(AsynchronousSearchIdConverter.java:49)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests.lambda$testAsynchronousSearchIdParsingFailure$0(AsynchronousSearchIdTests.java:36)
            at org.opensearch.search.asynchronous.id.AsynchronousSearchIdTests$$Lambda/0x00007f8a934091b8.run(Unknown Source)
            at org.apache.lucene.tests.util.LuceneTestCase._expectThrows(LuceneTestCase.java:3044)
            at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2884)
            ... 2 more

@peterzhuamazon
Copy link
Member

Seems flaky, rerun pass.

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member

Normal test pass and the multi node test is a different issue.

@peterzhuamazon
Copy link
Member


* Where:
Build file '/local/home/zhujiaxi/asynchronous-search-andrross/build.gradle' line: 391

* What went wrong:
Execution failed for task ':asynSearchCluster#mixedClusterTask'.
> `cluster{::asynSearchCluster0}` failed to wait for cluster health yellow after 40 SECONDS
    IO error while waiting cluster
    503 Service Unavailable

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon merged commit 9e65ea4 into opensearch-project:main Feb 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants