-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard field use only 3-gram to index #17349
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 3abbea7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfroh Is this worth creating a rolling upgrade test case for to ensure compatibility across the versions?
@HUSTERGS Can you rebase this with the latest from main? I think the bwc tests are failing due to a version bump.
3abbea7
to
b910b03
Compare
Signed-off-by: gesong.samuel <[email protected]>
Signed-off-by: gesong.samuel <[email protected]>
b910b03
to
b3576d9
Compare
❌ Gradle check result for b3576d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky tests: #17347 |
Oh, shoot! That one is my fault. I made it "less flaky" a couple of weeks ago, but apparently missed something. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17349 +/- ##
============================================
+ Coverage 72.41% 72.45% +0.04%
+ Complexity 65569 65557 -12
============================================
Files 5291 5291
Lines 304338 304321 -17
Branches 44181 44179 -2
============================================
+ Hits 220376 220495 +119
+ Misses 65917 65751 -166
- Partials 18045 18075 +30 ☔ View full report in Codecov by Sentry. |
Thanks @HUSTERGS. Want to take a crack at adding rolling upgrade tests to ensure compatibility across versions? It should be fairly straightforward to add a new case in the rest-api-spec test framework. In the "old_cluster" step you'll write some data to an index and verify a wildcard search returns expected results, then in the "mixed_cluster" and "upgraded_cluster" you'll just do the same search and verify you get the same results. Here's a commit where something similar was done for a geo field: c40014f |
❌ Gradle check result for e972562: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e972562
to
d0b29ad
Compare
❌ Gradle check result for d0b29ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d0b29ad
to
f82a1eb
Compare
❌ Gradle check result for f82a1eb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: gesong.samuel <[email protected]>
f82a1eb
to
273ff76
Compare
❌ Gradle check result for 273ff76: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: gesong.samuel <[email protected]>
Description
Accorrding the test result of #17099 , change wildcard field to only index 3-gram of the input data, instead of 1-3 gram, to reduce the overall index size caused by long positing list of single and double charaters, which is not really helpful when search. And also help to increase the write speed.
Related Issues
Resolves #17099
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.