Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Values and Filter Sidebar Fields By Type functionality for Discover #9386

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Feb 13, 2025

Description

Adds a Cypress test spec for the Top Values and Filter Sidebar Fields by Type functionality for the Discover page.

Issues Resolved

closes #8946

Screenshot

sidebar_1.mp4
sidebar_2.mp4
sidebar_3.mp4
sidebar_4.mp4
sidebar_5.mp4
sidebar_6.mp4
sidebar_7.mp4
sidebar_8.mp4
sidebar_9.mp4
sidebar_10.mp4
sidebar_11.mp4
sidebar_12.mp4

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see sidebar.spec.js. Run the test spec.

Changelog

  • test: Add Top Values and Filter Sidebar Fields by Type testing for the Discover Page.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (4d55b4d) to head (8705a3e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9386      +/-   ##
==========================================
- Coverage   61.72%   61.71%   -0.01%     
==========================================
  Files        3817     3817              
  Lines       91860    91860              
  Branches    14551    14551              
==========================================
- Hits        56697    56695       -2     
- Misses      31507    31508       +1     
- Partials     3656     3657       +1     
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (-0.01%) ⬇️
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative backport 2.x v2.20.0 labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative v2.20.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Results Display and Interaction in Table, Side panel] TESTID-140: Side bar
2 participants