Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MDS support for index pattern validate script #9371

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raintygao
Copy link
Contributor

Description

feat: Add MDS support for index pattern validate script

Screenshot

No UI change

Testing the changes

Turn on/off the MDS, and then visit index pattern script field edit page, the API won't break down any more if editing an index pattern on remote data source.

Changelog

  • feat: Add MDS support for index pattern validate script

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.70%. Comparing base (21f1f73) to head (aaaf852).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...management/server/routes/preview_scripted_field.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9371      +/-   ##
==========================================
+ Coverage   61.68%   61.70%   +0.02%     
==========================================
  Files        3816     3816              
  Lines       91829    91830       +1     
  Branches    14543    14544       +1     
==========================================
+ Hits        56649    56668      +19     
+ Misses      31521    31506      -15     
+ Partials     3659     3656       -3     
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.18% <ø> (+<0.01%) ⬆️
Linux_4 28.90% <50.00%> (-0.01%) ⬇️
Windows_1 29.00% <ø> (?)
Windows_2 56.41% <ø> (ø)
Windows_3 39.18% <ø> (?)
Windows_4 28.90% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving on MDS integration with core features. Could you add more details to the PR to explain what the script feature does, what's the issue, and what benefit does MDS integration bring us? Including a video or gif might help others to better understand! @raintygao

@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Feb 12, 2025
@zhongnansu zhongnansu added the enhancement New feature or request label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor enhancement New feature or request multiple datasource multiple datasource project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants