Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] add more osd namespacing #9358

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

angle943
Copy link
Contributor

@angle943 angle943 commented Feb 8, 2025

Description

  • add more namespaced custom commands to make neo and main in sync:

BREAKING CHANGES:

cy.navigateToWorkSpaceHomePage -> cy.osd.navigateToWorkSpaceHomePage
cy.navigateToWorkSpaceSpecificPage -> cy.osd.navigateToWorkSpaceSpecificPage
cy.waitForLoader -> cy.osd.waitForLoader

cy.updateSaveQuery -> cy.osd.updateSavedQuery
cy.loadSaveQuery -> cy.osd.loadSavedQuery
cy.clearSaveQuery -> cy.clearSavedQuery
cy.deleteSaveQuery -> cy.deleteSavedQuery

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <[email protected]>
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (4e21765) to head (2d83c3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9358   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91860    91860           
  Branches    14551    14551           
=======================================
  Hits        56695    56695           
  Misses      31508    31508           
  Partials     3657     3657           
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (ø)
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Kim <[email protected]>
Copy link
Collaborator

@LDrago27 LDrago27 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to have these commands not part of the command.osd.js file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am adding these to .osd. in Neo because we have some code divergence. In neo they exist in both regular and .osd. namespace, but to avoid having people to use the regular one in Github repo, i am removing it from here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. So you are cleaning up the individual commands.js files and consolidating them within the commands.osd.js under the osd namespace to avoid potential conflicts with a similarly named command in neo.

@angle943 angle943 marked this pull request as draft February 12, 2025 22:34
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants