-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] add more osd namespacing #9358
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Justin Kim <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9358 +/- ##
=======================================
Coverage 61.71% 61.71%
=======================================
Files 3817 3817
Lines 91860 91860
Branches 14551 14551
=======================================
Hits 56695 56695
Misses 31508 31508
Partials 3657 3657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to have these commands not part of the command.osd.js
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am adding these to .osd.
in Neo because we have some code divergence. In neo they exist in both regular and .osd.
namespace, but to avoid having people to use the regular one in Github repo, i am removing it from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So you are cleaning up the individual commands.js files and consolidating them within the commands.osd.js under the osd namespace to avoid potential conflicts with a similarly named command in neo.
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Signed-off-by: Justin Kim <[email protected]>
Description
BREAKING CHANGES:
Changelog
Check List
yarn test:jest
yarn test:jest_integration