Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Filter out recent items with errors #9346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Feb 7, 2025

Description

Filter out recent items which has errors(might be deleted)

Issues Resolved

Screenshot

image

Remove [eCommerce] Sales by Gender

image

Testing the changes

Changelog

  • fix: [workspace] filter out recent items which have errors

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Feb 7, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (2ff6f19) to head (2bc9ab8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9346   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3816     3816           
  Lines       91829    91830    +1     
  Branches    14543    14543           
=======================================
+ Hits        56668    56669    +1     
  Misses      31506    31506           
  Partials     3655     3655           
Flag Coverage Δ
Linux_1 28.99% <0.00%> (-0.01%) ⬇️
Linux_2 56.46% <100.00%> (+<0.01%) ⬆️
Linux_3 39.18% <0.00%> (-0.01%) ⬇️
Linux_4 28.90% <0.00%> (-0.01%) ⬇️
Windows_1 29.00% <0.00%> (-0.01%) ⬇️
Windows_2 56.42% <100.00%> (+<0.01%) ⬆️
Windows_3 39.18% <0.00%> (-0.01%) ⬇️
Windows_4 28.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants