Bundle analyzer on plugins #9320
Conversation
Signed-off-by: Ruchi Sharma <[email protected]>
ruchidh
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 9320.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 9320.yml under folder changelogs/fragments to complete this PR. File still missing. |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Signed-off-by: Ruchi Sharma <[email protected]>
There was a problem hiding this comment.
Are these bundle size limits? Can you share how these number comes up? Why are we deleting some?
There was a problem hiding this comment.
Actually, these are not deleted manually. The file was updated 4 years back with old plugins, which are not supported now. This is all auto updated with new plugins and relevant package size only.
There was a problem hiding this comment.
ruchidh#3 - forked pr with results
github-actions
bot
added
Skip-Changelog
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feature". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
failed changeset
and removed
Skip-Changelog
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feature". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
1 similar comment
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feature". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
| const delta = metric.value - metric.limit; | ||
| const deltaPercentage = Math.round((delta / metric.limit) * 100 * 100) / 100; | ||
|
|
||
| if (deltaPercentage > 20) { |
There was a problem hiding this comment.
This percentage seems quite high. For reference, if we had 5 PRs that increased the bundle size by 15% we'd get no notification and would have more than doubled the bundle size.
| : metric.value + DEFAULT_BUDGET; | ||
| existingLimit != null && existingLimit >= metric.value ? existingLimit : metric.value; | ||
|
|
||
| // Update the bundle size variation file for bundles that exceed the limit by more than 20%. |
There was a problem hiding this comment.
Is this to update the baseline or for reporting to the CI for it to decide whether or not to fail?
Description
This PR will create bundle variation percentage report in pr comment for a newly added performance testing from existing limit size of bundle for every Open PR against main. If the variation is more than 20%, you will see the list of plugins name which are breaking the thereshold of bundle size limit variation in comments.
Limit is updated with package size to current date.
For any plugin from now on, if have bundle size variation more than 20% will get report.
Screenshot
No required
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration