chore: update to lsprotocol-2024.0.0b1 #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
previously approved these changes
Oct 4, 2024
examples/servers/code_actions.py
Outdated
| @@ -67,6 +67,7 @@ def code_actions(params: types.CodeActionParams): | |||
| title=f"Evaluate '{match.group(0)}'", | |||
| kind=types.CodeActionKind.QuickFix, | |||
| edit=types.WorkspaceEdit(changes={document_uri: [text_edit]}), | |||
| tags=[types.CodeActionTag.LlmGenerated], | |||
There was a problem hiding this comment.
Perhaps we could drop this? It's nice to be able to show the new features of lsprotocol but I wonder if it might confuse someone new to language servers into thinking it's required?
There was a problem hiding this comment.
Yes we can. I will make the update.
karthiknadig
force-pushed
the
lsp-update
branch
from
d7359e2
to
48a3a6d
Compare
karthiknadig
force-pushed
the
lsp-update
branch
from
b0bbe49
to
8518c30
Compare
|
@alcarney Sorry for a delayed update. I have removed the LLM tag from the tests. |
alcarney
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Updating lsprotocol to the latest version. Includes proposed LLM features.
Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: