-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCode OF compiled $(ARCHS) instead of $(ARCHS_STANDARD) #7046
Conversation
Thanks! I'll test this out tomorrow and see if it does it all correctly. My thought was to set So if someone set |
@dimitre thanks for the reminder! Thinking about this more I think all we should do to address this is to set This allows people to compile examples faster and when they want to share across platforms they can use the 'Any Mac' target. OF doesn't get recompiled often and so I think it is simpler to leave it as a universal lib. One other thing that would be great is if the new json formatted template could be |
Nice' I've sent a PR for json format. But one thing I liked a lot in your previous suggestion (compile the core in actual architecture only) is it is faster to work on the core, test PRs, probably github actions too. So I'll be using that in my setup :) |
@dimitre ahh - awesome didn't think it was already working like that. Yeah, I think I also backtracked a bit on the idea of ARCHS based on thinking for CI at least we do want build the core Universal as we need to test both architectures. Then thinking that for most users it will compile once for Debug and Release and then as long as the examples and projects are native only, you are not doing extra compiles for daily projects. But yeah for people working on OF itself - def is nice to disable other Archs. |
I think the can close this now - if the current behavior is Debug and Release only building active archs, that should be an improvement from before! Thanks @dimitre for looking into this! |
Hello @ofTheo I still want to discuss this one some more lol |
@dimitre sure thing! I think the main thing to do then would be to figure out how to pass the My Mac / Any Mac parameter through to the openFrameworksCompiled.xcodeProj similar to how we are doing for C++17:
That way openFrameworksCompiled could be set to "Active Architecture Only" and the main project would then pass through the target ( whether Intel or Arm The only downside to the CI not compiling OF for both is that we might miss errors that exist just on one platform ( which has come up in the past, like missing symbols or api calls ). But for the speed we'd gain maybe its okay? |
Yeah. don't you think it will automatically compile the core for the selected architectures automatically if binaries for the platform are not present? I can test this here. I think api calls are really standarized if we compile for different archs, lets say m1 and intel (which is the case here in this PR not different platforms) . |
In my tests it is building OK for Apple Silicon, Intel or Universal.
hopefully closes #7043