feat: Use parameterized view to fix memory issue #132
Merged
+168
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saraburns1 what changes would be required for this to work on the Superset side? |
|
Ian2012
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading all data into a materialized view, this creates a parameterized view that requires an org and course name. It's accessed by
select * from reporting.watched_video_duration(org_filter=['Org1','Org2'], course_name_filter=['course1','course2'])Ran with 50M row dataset. dbt build had no issues, dashboard load for all orgs & courses took ~3sec
Remove unit test (for now. will do a followup ticket to fix this and other tests we've had to remove)