Remember table sorting #1009
Remember table sorting #1009
Conversation
Tables can be sorted by columns, ascending or descending. However, when switching to a different tab and back again, the sorting reverts to the default. With this change, the sorting is remembered. Does not persist the sorting, meaning it still reverts to the default after a page reload. I did not do this because the only to way to get rid of persisted sorting would be to the clear the browsers cache, and I did not want alienate people. Also sneakily changes the default sorting of the series table in the same way as opencast#1008.
|
This pull request is deployed at test.admin-interface.opencast.org/1009/2025-02-18_08-23-43/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
There was a problem hiding this comment.
This appears to be causing the following exception every time the page is started (eg F5, or a fresh navigation).
2025-01-16 17:00:51,271 | WARN | (WebApplicationExceptionMapper:73) - javax.ws.rs.WebApplicationException: HTTP 400 Bad Request
at org.opencastproject.index.service.util.RestUtils.parseSortQueryParameter(RestUtils.java:233)
at org.opencastproject.adminui.endpoint.AbstractEventEndpoint.getEvents(AbstractEventEndpoint.java:2668).
...
Note that it doesn't continually do this with the normal content requests, just the first-boot. Seems to work just fine, just an ugly trace in the logs.
Not only do we not want the empty string, we in fact don't want any falsy values.
There was a problem hiding this comment.
Can confirm that this is working. @gregorydlogan did you want to take another look at the thing you commented on? Otherwise I'd say it can get merged.
|
This pull request has conflicts ☹ |
Tables can be sorted by columns, ascending or descending. However, when switching to a different tab and back again, the sorting reverts to the default. With this change, the sorting is remembered.
Does not persist the sorting, meaning it still reverts to the default after a page reload. I did not do this because the only to way to get rid of persisted sorting would be to the clear the browsers cache, and I did not want alienate people.
Also sneakily changes the default sorting of the series table in the same way as #1008.
How to test this
PR can be tested as is, no other dependencies or configuration necessary.
Bildschirmaufzeichnung.vom.2024-12-12.11-44-03.webm