move Naming/ClassAndModuleCamelCase exclusion

Declare this once in the Rubocop config instead of including it each generated class by way of the template.
open-telemetry · Mar 19, 2024 · 44bd254 · 44bd254
1 parent 83d9ae9
commit 44bd254
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/semantic_conventions/.rubocop.yml b/semantic_conventions/.rubocop.yml
@@ -26,6 +26,9 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Enabled: false
 
+Naming/ClassAndModuleCamelCase:
+  Exclude:
+    - lib/opentelemetry/semantic_conventions/**/*.rb
 Naming/FileName:
   Exclude:
     - lib/opentelemetry-semantic_conventions.rb

diff --git a/semantic_conventions/lib/opentelemetry/semantic_conventions/1.10.0/resource.rb b/semantic_conventions/lib/opentelemetry/semantic_conventions/1.10.0/resource.rb
@@ -5,7 +5,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 module OpenTelemetry
-  module SemanticConventions_1_10_0 # rubocop:disable Naming/ClassAndModuleCamelCase
+  module SemanticConventions_1_10_0
     # https://github.com/open-telemetry/opentelemetry-specification/tree/v1.10.0/specification
     module Resource
       # Name of the cloud provider

diff --git a/semantic_conventions/lib/opentelemetry/semantic_conventions/1.10.0/trace.rb b/semantic_conventions/lib/opentelemetry/semantic_conventions/1.10.0/trace.rb
@@ -5,7 +5,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 module OpenTelemetry
-  module SemanticConventions_1_10_0 # rubocop:disable Naming/ClassAndModuleCamelCase
+  module SemanticConventions_1_10_0
     # https://github.com/open-telemetry/opentelemetry-specification/tree/v1.10.0/specification
     module Trace
       # The full invoked ARN as provided on the `Context` passed to the function (`Lambda-Runtime-Invoked-Function-Arn` header on the `/runtime/invocation/next` applicable)

diff --git a/semantic_conventions/lib/opentelemetry/semantic_conventions/1.20.0/resource.rb b/semantic_conventions/lib/opentelemetry/semantic_conventions/1.20.0/resource.rb
@@ -7,7 +7,7 @@
 require_relative '../1.10.0/resource'
 
 module OpenTelemetry
-  module SemanticConventions_1_20_0 # rubocop:disable Naming/ClassAndModuleCamelCase
+  module SemanticConventions_1_20_0
     # https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/
     module Resource
       def self.const_missing(const_name)

diff --git a/semantic_conventions/lib/opentelemetry/semantic_conventions/1.20.0/trace.rb b/semantic_conventions/lib/opentelemetry/semantic_conventions/1.20.0/trace.rb
@@ -7,7 +7,7 @@
 require_relative '../1.10.0/trace'
 
 module OpenTelemetry
-  module SemanticConventions_1_20_0 # rubocop:disable Naming/ClassAndModuleCamelCase
+  module SemanticConventions_1_20_0
     # https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/
     module Trace
       def self.const_missing(const_name)

diff --git a/semantic_conventions/templates/semantic_conventions.j2 b/semantic_conventions/templates/semantic_conventions.j2
@@ -7,7 +7,7 @@
 require_relative '../{{prev_spec_version}}/{{kind}}'
 
 module OpenTelemetry
-  module SemanticConventions_{{spec_version | replace(".", "_")}} # rubocop:disable Naming/ClassAndModuleCamelCase
+  module SemanticConventions_{{spec_version | replace(".", "_")}}
     # https://github.com/open-telemetry/opentelemetry-specification/blob/v{{spec_version}}/specification/
     module {{module}}
     {%- if (prev_spec_version | string()) != "" %}