fix(extension): consider requests failed when status code is not 2xx #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pkarakal
force-pushed
the
otel-collector-registration
branch
from
25a79e4 to
737071e
Compare
tylerbenson
approved these changes
Jan 13, 2025
tylerbenson
reviewed
Jan 13, 2025
pkarakal
force-pushed
the
otel-collector-registration
branch
from
737071e to
ffc692c
Compare
tylerbenson
reviewed
Jan 13, 2025
pkarakal
force-pushed
the
otel-collector-registration
branch
from
ffc692c to
db3f092
Compare
pkarakal
force-pushed
the
otel-collector-registration
branch
from
db3f092 to
bce5f1b
Compare
tylerbenson
approved these changes
Jan 13, 2025
serkan-ozal
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the extension api client to consider requests as failed only when their status code is not 2xx. This is mostly required since AWS Lambda has updated the status code returned on successful extension registration from 200 to 201 and thus all lambda invocations fail.