Minimum go version dependency downgraded back to 1.22.0 in various packages #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/test-downgrade-go-1.22
branch
from
b989e26 to
0d0f7bb
Compare
codeboten
changed the title
codeboten
changed the title
codeboten
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6073 +/- ##
=======================================
- Coverage 82.2% 82.2% -0.1%
=======================================
Files 273 273
Lines 23674 23674
=======================================
- Hits 19478 19476 -2
- Misses 3849 3851 +2
Partials 347 347 |
XSAM
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Should we wait for the open-telemetry/opentelemetry-proto-go#225?
happy to go either ways |
codeboten
force-pushed
the
codeboten/test-downgrade-go-1.22
branch
from
0d0f7bb to
5294e26
Compare
|
@XSAM updated with the release of 1.5.0 |
MrAlias
approved these changes
Jan 6, 2025
1 task
dmathieu
approved these changes
Jan 7, 2025
pellared
approved these changes
Jan 7, 2025
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
codeboten
force-pushed
the
codeboten/test-downgrade-go-1.22
branch
from
1900938 to
9279a8b
Compare
|
Rebased to address the merge conflicts |
1 task
MrAlias
added a commit
that referenced
this pull request
Jan 17, 2025
## Overview ### Changed - Remove the notices from `Logger` to make the whole Logs API user-facing in `go.opentelemetry.io/otel/log`. (#6167) ### Fixed - Relax minimum Go version to 1.22.0 in various modules. (#6073) - The `Type` name logged for the `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` client is corrected from `otlphttpgrpc` to `otlptracegrpc`. (#6143) - The `Type` name logged for the `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlphttpgrpc` client is corrected from `otlphttphttp` to `otlptracehttp`. (#6143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pulling in a change to opentelemetry-proto-go that allows us to set the minimum go version back down to 1.22.0.
This depends on open-telemetry/opentelemetry-proto-go#224
Fixes #5969