Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tyler Yahn <[email protected]>
  • Loading branch information
dashpole and MrAlias committed Aug 18, 2022
1 parent 99f5c77 commit 5383382
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bridge/opencensus/opencensusmetric/internal/metric.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func ConvertMetrics(ocmetrics []*ocmetricdata.Metric) ([]metricdata.Metrics, err
return otelMetrics, aggregatedError
}

// convertAggregation produces an aggregation based on the opencensus Metric.
// convertAggregation produces an aggregation based on the OpenCensus Metric.
func convertAggregation(metric *ocmetricdata.Metric) (metricdata.Aggregation, error) {
labelKeys := metric.Descriptor.LabelKeys
switch metric.Descriptor.Type {
Expand Down Expand Up @@ -215,5 +215,5 @@ func convertUnit(u ocmetricdata.Unit) unit.Unit {
case ocmetricdata.UnitMilliseconds:
return unit.Milliseconds
}
return unit.Unit("")
return unit.Unit(string(u))
}

0 comments on commit 5383382

Please sign in to comment.