-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http semantic conventions notice to changelog #6737
base: main
Are you sure you want to change the base?
Conversation
We should wait for #6710 to be merged before merging this one. |
CHANGELOG.md
Outdated
@@ -8,11 +8,24 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|||
## [Unreleased] | |||
|
|||
### ⚠️ Notice ⚠️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be it's own section.
What about alert syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved it to the deprecated section with a warning.
c2c2cfa
to
3bdad50
Compare
CHANGELOG.md
Outdated
> [!WARNING] | ||
> This is the last version to use Semantic Conventions v1.20.0 for HTTP libraries | ||
by default. The next version (0.61.0) will default to v1.26.0, and the | ||
following one (0.62.0) will drop support for Semantic Conventions v1.20.0 | ||
> | ||
> You can switch to the new Semantic Conventions right now by setting the | ||
`OTEL_HTTP_CLIENT_COMPATIBILITY_MODE=http/dup` environment variable in your | ||
application. | ||
> | ||
> See also the [HTTP semantic conventions stability | ||
migration](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/http-migration.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest putting this in the beginning of the changelog for given version. I mean just before ### Added
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I did at first. But @MrAlias seems to want it into another section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrAlias said the opposite.
This shouldn't be it's own section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what @MrAlias intended, so I've moved it back to the top of the changelog.
Closes #6731