Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #2470 (some windows support for ffmpeg calls) #3175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dtraparic
Copy link

@dtraparic dtraparic commented Sep 11, 2024

Motivation

Support on Windows

Modification

  1. Added quotes around paths given to ffmpeg command (executed by mmcv.video.processing.py:convert_video() ), in order to support the spaces in windows paths.
  2. Changed "which" to "where" when the platform is Windows in mmcv.utils.misc.py:_check_executable()

BC-breaking (Optional)

No

Use cases (Optional)

No new use case

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

None, I've tried to run the linting tools, but I got some exceptions that I didn't understand when trying to use them, maybe they don't work on Windows.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Traparic seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

David Traparic added 2 commits September 13, 2024 17:00
… for grabcut+SITI analysis for perceptual study, but it needs some heavy refacto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants