feat(flagd): migrate file to own provider type #1173
+149
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
aepfli
force-pushed
the
feat/add_new_provider_type
branch
from
c233a4f to
b853a29
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/add_new_provider_type
branch
from
b853a29 to
0b11534
Compare
Signed-off-by: Simon Schrottner <[email protected]>
…er_type Signed-off-by: Simon Schrottner <[email protected]>
chrfwow
reviewed
Feb 6, 2025
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java
Outdated
Show resolved
Hide resolved
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Outdated
Show resolved
Hide resolved
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Show resolved
Hide resolved
toddbaert
approved these changes
Feb 6, 2025
aepfli
force-pushed
the
feat/add_new_provider_type
branch
from
46bdc06 to
543e516
Compare
beeme1mr
approved these changes
Feb 6, 2025
aepfli
force-pushed
the
feat/add_new_provider_type
branch
2 times, most recently
from
d110b0a to
d8b7139
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/add_new_provider_type
branch
from
d8b7139 to
2137928
Compare
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/add_new_provider_type
branch
from
f852866 to
97f48ae
Compare
also added the missing field of poll interval now to the implementation |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(open-feature/flagd#1525)