fix: add support for unix socket connection in sync service (#1518) #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
aepfli
requested changes
Feb 13, 2025
…eature#1518) Signed-off-by: Alexandra Oberaigner <[email protected]>
Signed-off-by: Alexandra Oberaigner <[email protected]>
alexandraoberaigner
force-pushed
the
feat/(sync)-support-for-unix-socket
branch
from
27a16f9 to
e358f09
Compare
Signed-off-by: Alexandra Oberaigner <[email protected]>
alexandraoberaigner
force-pushed
the
feat/(sync)-support-for-unix-socket
branch
from
c392849 to
4b238e5
Compare
Signed-off-by: Alexandra Oberaigner <[email protected]>
dosubot
bot
added
the
size:L
aepfli
approved these changes
Feb 13, 2025
toddbaert
requested review from
djosephsen,
bacherfl,
aepfli,
alemrtv and
warber
Signed-off-by: alexandraoberaigner <[email protected]>
toddbaert
approved these changes
Feb 18, 2025
|
@alexandraoberaigner I pushed a change just to resolve a go.mod conflict coming from main. |
chrfwow
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
adds support for unix sockets in sync service
Related Issues
Fixes #1518
How to test
start flagd with the new option
-e /tmp/socketpathand try to connect with an in-process provider to the same socket path & request a flag