fix: Address issue with newline characters when running Logging Hook Unit Tests on linux #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I noticed when I ran these tests on a WSL Ubuntu instance the Logging Hook tests fail. It appears I never normalized or excluded newline characters when asserting equal. * Remove Assert.Contains examples as this does not provide an overload for ignore newline characters Signed-off-by: Kyle Julian <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 39 39
Lines 1601 1601
Branches 173 173
=======================================
Hits 1379 1379
Misses 186 186
Partials 36 36 ☔ View full report in Codecov by Sentry. |
|
Hey @kylejuliandev, is this ready for a review? It's marked as a draft, so I wasn't sure. Thanks! |
|
Hey @beeme1mr, I've moved it from draft now I'm not sure this change is strictly necessary, as the pipelines can execute (on Ubuntu) these tests fine. But this potentially improves the experience for those using the WSL as well as Windows to develop and contribute to this project |
askpt
approved these changes
Feb 17, 2025
beeme1mr
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
I noticed when I ran the LoggingHook unit tests on a WSL Ubuntu instance the some tests fails due to new line characters. It appears I never normalized or excluded newline characters when asserting equal
I also removed the
Assert.Containssnippets as the content and layout of the log message is asserted in the other tests. This Assert method does not have an overload for ignoring new line charactersI assume the GitHub CI runner may be ignore the line endings by default?
Related Issues
Notes
Follow-up Tasks
How to test