Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since compiler generated stick/unstick is default on, change new option to disable it #3073

Merged

Conversation

AlexandreEichenberger
Copy link
Collaborator

Change option to be more in-line with default, where options that are default on are explicitly disabled using an appropriate --disable-XXX flag

Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
…turn it off is disable-compiler-stick-unstick

Signed-off-by: Alexandre Eichenberger <[email protected]>
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexandreEichenberger AlexandreEichenberger merged commit 86b8f18 into onnx:main Feb 13, 2025
6 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16295 [push] Since compiler generated... started at 17:28

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16297 [push] Since compiler generated... started at 18:28

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16297 [push] Since compiler generated... aborted after 1 hr 27 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16295 [push] Since compiler generated... aborted after 1 hr 28 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants