Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix weak hash #3070

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix weak hash #3070

merged 2 commits into from
Feb 10, 2025

Conversation

Sunny-Anand
Copy link
Collaborator

@Sunny-Anand Sunny-Anand commented Feb 7, 2025

This updates the sha algorithm for the docker images from sha1 to sha3_256. I have avoided renaming the use of sha1 in various docker files for now with something as generic as hash, but if there is feedback to change those variable names from tied to an algorithm to being generic, I can do that as feedback.

Signed-off-by: Sunny Anand <[email protected]>
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunny-Anand Sunny-Anand merged commit d6da8b2 into onnx:main Feb 10, 2025
7 checks passed
@Sunny-Anand Sunny-Anand deleted the fix-vulenrability branch February 10, 2025 17:51
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16273 [push] fix weak hash (#3070) S... started at 11:52

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16275 [push] fix weak hash (#3070) S... started at 12:52

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15302 [push] fix weak hash (#3070) S... started at 13:11

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16275 [push] fix weak hash (#3070) S... passed after 2 hr 25 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16273 [push] fix weak hash (#3070) S... passed after 2 hr 28 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15302 [push] fix weak hash (#3070) S... passed after 4 hr 43 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants