-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate adding alloca_scope to scf passes (for parallel with NNPA) #2684
Migrate adding alloca_scope to scf passes (for parallel with NNPA) #2684
Conversation
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jenkins Linux s390x Build #13914 [push] Migrate adding alloca_sc... started at 10:13 |
Jenkins Linux ppc64le Build #12911 [push] Migrate adding alloca_sc... started at 10:22 |
Jenkins Linux amd64 Build #13887 [push] Migrate adding alloca_sc... started at 09:13 |
Jenkins Linux amd64 Build #13887 [push] Migrate adding alloca_sc... passed after 1 hr 10 min |
Jenkins Linux s390x Build #13914 [push] Migrate adding alloca_sc... passed after 1 hr 35 min |
Jenkins Linux ppc64le Build #12911 [push] Migrate adding alloca_sc... passed after 1 hr 55 min |
Previous approach of adding
alloca_scope
at the affine level did not work for NNPA as additional passes ofcanonicalize
were called between addingalloca_scope
and handling of buffers when generating NNPA code.This problem is fixed here by migrating that pass to work with
scf
and calling that pass just before handling buffers.Once this is well established, we should probably remove the old pass at the affine level as its unlikely to be useful anymore.
With this fix, Roberta passes with NNPA: