fix select: solved performance issue for data() nethod

olton · Jan 31, 2025 · 4836dd6 · 4836dd6
1 parent b67836d
commit 4836dd6
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/lib/metro.js b/lib/metro.js
@@ -16107,16 +16107,20 @@
         const option2 = $3("<option>").attr("value", val).text(title3 ? title3 : val);
         element2.append(option2);
         if (selected) {
+          if (element2[0].multiple) {
+          } else {
+            element2.find("option").prop("selected", false);
+          }
           option2.prop("selected", true);
         }
-        this._createOptions();
         return this;
       },
       addOptions: function(values) {
         const that = this;
         if (!values) {
           return this;
         }
+        this.observer.disconnect();
         if (Array.isArray(values)) {
           $3.each(values, function() {
             const o2 = this;
@@ -16131,6 +16135,11 @@
             that.addOption(key, val);
           });
         }
+        this._createOptions();
+        this.observer.observe(element[0], {
+          childList: true,
+          subtree: true
+        });
         return this;
       },
       removeOption: function(val) {

diff --git a/lib/metro.js.map b/lib/metro.js.map
diff --git a/source/components/select/select.js b/source/components/select/select.js
@@ -806,10 +806,15 @@
             element.append(option);
 
             if (selected) {
+                if (element[0].multiple) {
+                    // nothing
+                } else {
+                    element.find("option").prop("selected", false);
+                }
                 option.prop("selected", true);
             }
 
-            this._createOptions();
+            // this._createOptions();
 
             return this;
         },
@@ -821,6 +826,8 @@
                 return this;
             }
 
+            this.observer.disconnect();
+
             if (Array.isArray(values)) {
                 $.each(values, function () {
                     const o = this;
@@ -836,6 +843,13 @@
                 });
             }
 
+            this._createOptions();
+
+            this.observer.observe(element[0], {
+                childList: true,
+                subtree: true,
+            })
+
             return this;
         },