Clean up search #5854
Open
Clean up search #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xu-shawn
force-pushed
the
cleanup_search
branch
2 times, most recently
from
0de6059 to
05b008d
Compare
|
Adding all these branches to compute bonusScale is probably not a good thing. |
|
I think both the old and new implementation have branching https://godbolt.org/z/6ob5Tscfd, though I can submit a test if needed. |
|
Interesting the new assembly is more similar to the original than I would have thought but still not the same. I would run an STC just to be sure but see what the maintainers say. |
|
drop the unnecessary comments and run a non regression test to silence the doubters : D |
xu-shawn
force-pushed
the
cleanup_search
branch
from
05b008d to
b0ae7d1
Compare
|
Passed STC Non-reg: https://tests.stockfishchess.org/tests/view/67a0ea670774dfd78deb23cd |
xu-shawn
force-pushed
the
cleanup_search
branch
from
b0ae7d1 to
656b25e
Compare
|
Rebased on #5865 |
xu-shawn
force-pushed
the
cleanup_search
branch
from
656b25e to
af0b067
Compare
|
Rebased |
xu-shawn
force-pushed
the
cleanup_search
branch
from
af0b067 to
efe9b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PvNode || cutNode)with!allNodePassed Non-regression STC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 389472 W: 102457 L: 102622 D: 184393
Ptnml(0-2): 1676, 41887, 107798, 41676, 1699
https://tests.stockfishchess.org/tests/view/67a0ea670774dfd78deb23cd
bench 3088494