Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement handling and/or expressions #165

Merged
merged 16 commits into from
Feb 4, 2025
Merged

implement handling and/or expressions #165

merged 16 commits into from
Feb 4, 2025

Conversation

esc
Copy link
Member

@esc esc commented Jan 28, 2025

As title. Fixes #148

sklam
sklam previously requested changes Jan 29, 2025
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Implementation is not handling more than one and/or. For example, x and y and z or x or y or z.

I used test like: (x > 0 and x < 10 and x) or (y > 0 and y < 10 and y)

  1. if x and y is not handled. Need to add testing that uses and/or with branches and loops.

@esc
Copy link
Member Author

esc commented Jan 29, 2025

  1. Implementation is not handling more than one and/or. For example, x and y and z or x or y or z.

I used test like: (x > 0 and x < 10 and x) or (y > 0 and y < 10 and y)

  1. if x and y is not handled. Need to add testing that uses and/or with branches and loops.

Yeah, it's still in progress. I'll let you know when it is ready for review.

@esc esc marked this pull request as draft January 29, 2025 22:21
@esc
Copy link
Member Author

esc commented Jan 29, 2025

  1. Implementation is not handling more than one and/or. For example, x and y and z or x or y or z.

I used test like: (x > 0 and x < 10 and x) or (y > 0 and y < 10 and y)

  1. if x and y is not handled. Need to add testing that uses and/or with branches and loops.

Yeah, it's still in progress. I'll let you know when it is ready for review.

I've converted this back to a draft as it was not yet ready for review.

@esc esc marked this pull request as ready for review January 30, 2025 15:35
@esc
Copy link
Member Author

esc commented Jan 30, 2025

  1. Implementation is not handling more than one and/or. For example, x and y and z or x or y or z.

I used test like: (x > 0 and x < 10 and x) or (y > 0 and y < 10 and y)

  1. if x and y is not handled. Need to add testing that uses and/or with branches and loops.

I added code and tests to satisfy the above, not sure how complex to make the tests.

@esc esc added the enhancement New feature or request label Jan 30, 2025
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just some spelling nitpicks.

numba_rvsdg/core/datastructures/ast_transforms.py Outdated Show resolved Hide resolved
numba_rvsdg/core/datastructures/ast_transforms.py Outdated Show resolved Hide resolved
@sklam sklam dismissed their stale review February 3, 2025 21:39

updated

@esc esc requested a review from sklam February 3, 2025 22:45
@esc
Copy link
Member Author

esc commented Feb 4, 2025

@sklam thank you for the review.

@esc esc merged commit bf09ccf into main Feb 4, 2025
2 checks passed
@esc esc deleted the handle_bool_op branch February 4, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle and and or
2 participants