Merge pull request #131 from nspcc-dev/org-linter

Org-wide linter

.github/workflows/go.yml

@@ -13,17 +13,7 @@ on:
 jobs:
   lint:
     name: Lint
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: 'go.mod'
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
-        with:
-          version: latest
+    uses: nspcc-dev/.github/.github/workflows/go-linter.yml@master
 
   test:
     name: Test

.gitignore

@@ -1,4 +1,5 @@
 /vendor
+.golangci.yml
 
 # TLC Model Checker files
 formal-models/*/*.toolbox/

dbft.go

@@ -698,9 +698,9 @@ func (d *DBFT[H]) changeTimer(delay time.Duration) {
 	d.Timer.Reset(d.BlockIndex, d.ViewNumber, delay)
 }
 
-func (d *DBFT[H]) extendTimer(count time.Duration) {
+func (d *DBFT[H]) extendTimer(count int) {
 	if !d.CommitSent() && (!d.isAntiMEVExtensionEnabled() || !d.PreCommitSent()) && !d.ViewChanging() {
-		d.Timer.Extend(count * d.SecondsPerBlock / time.Duration(d.M()))
+		d.Timer.Extend(time.Duration(count) * d.SecondsPerBlock / time.Duration(d.M()))
 	}
 }
 

helpers.go

@@ -56,5 +56,8 @@ func (c *cache[H]) addMessage(m ConsensusPayload[H]) {
 		msgs.preCommit[m.ValidatorIndex()] = m
 	case CommitType:
 		msgs.commit[m.ValidatorIndex()] = m
+	default:
+		// Others are recoveries and we don't currently use them.
+		// Theoretically messages could be extracted.
 	}
 }

internal/consensus/amev_block.go

@@ -36,7 +36,7 @@ func NewAMEVBlock(pre dbft.PreBlock[crypto.Uint256], cnData [][]byte, m int) dbf
 	tx := Tx64(math.MaxInt64 - int64(sum))
 	res.transactions = append(preB.initialTransactions, &tx)
 
-	// Rebuild Merkle root for the new set of transations.
+	// Rebuild Merkle root for the new set of transactions.
 	txHashes := make([]crypto.Uint256, len(res.transactions))
 	for i := range txHashes {
 		txHashes[i] = res.transactions[i].Hash()

internal/consensus/recovery_message.go

@@ -65,6 +65,8 @@ func (m *recoveryMessage) AddPayload(p dbft.ConsensusPayload[crypto.Uint256]) {
 		}
 		copy(cc.Signature[:], p.GetCommit().Signature())
 		m.commitPayloads = append(m.commitPayloads, cc)
+	default:
+		// Other types (recoveries) can't be packed into recovery.
 	}
 }