Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gui_Button_V1.ui #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Bud1994
Copy link

@Bud1994 Bud1994 commented Sep 16, 2020

-Capitalised buttons, as well as giving them better descriptions
s
-Overlay UI
Tweaked colour scheme so it is uniform,
Shrunk UI no longer blocks exp bar
Made close button bigger, clear and uniform with rest of UI
a

Tweaked UI and Tags
@notablackbear
Copy link
Owner

notablackbear commented Sep 17, 2020

Thanks for submitting. I am going to leave the colors as is, since by design I wanted to include a colorblind friendly scheme that shows which items are which class quickly. The reason is that you want to find certain colors first when moving them to your inventory from stash in order to avoid a 'tetris' situation. I feel the colors assist with that, and are in order from top left to bottom right as is traditional for english reading. I think the caps are good however, and the formatting does look better.

If you undo the color changes, I'll happily merge this.

Feel free to adjust colors as you see fit for your own usage.

@Bud1994
Copy link
Author

Bud1994 commented Sep 17, 2020

Fair enough, that all makes sense. I have reverted the file back to the original colour scheme.

as

@Bud1994 Bud1994 closed this Sep 18, 2020
@notablackbear
Copy link
Owner

I see this got closed. The 'close' button looks different, in a positive way. Is this still the case?

@notablackbear notablackbear reopened this Sep 24, 2020
@Bud1994
Copy link
Author

Bud1994 commented Sep 24, 2020

Sorry closed it because the file had a lot of conflicts as you had update padding etc, been busy with work so not had a chance to sort conflicts out, layout is still all the same though

image

@EdwoG
Copy link

EdwoG commented Sep 24, 2020

the current overlay has a issue with moving around randomly
if you click anywhere except around the X (close) and you your mouse even for a pixel the top left corner will snap onto the cursor. This happens even if you click on refresh.
Hope that can get fixed together with the gui.

@EdwoG
Copy link

EdwoG commented Sep 24, 2020

image
the position you click-hold on one of those rectangle(and then move around), transitions into the same place in a rectangle same size in the top left corner

@Bud1994
Copy link
Author

Bud1994 commented Sep 24, 2020

I personally have not had any problems this error on my GUI version. This is my current GUI with the new padding that had been added.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants