Fix extra trailing '\0' char in uvwasi_path_readlink (#263)

nodejs · May 2, 2024 · 38d124c · 38d124c
1 parent 81ac54a
commit 38d124c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/uvwasi.c b/src/uvwasi.c
@@ -2199,7 +2199,7 @@ uvwasi_errno_t uvwasi_path_readlink(uvwasi_t* uvwasi,
 
   memcpy(buf, req.ptr, len);
   buf[len] = '\0';
-  *bufused = len + 1;
+  *bufused = len;
   uv_fs_req_cleanup(&req);
   return UVWASI_ESUCCESS;
 }

diff --git a/test/test-symlink.c b/test/test-symlink.c
@@ -56,7 +56,7 @@ int main(void) {
                              strlen(path) + 1,
                              &bufused);
   assert(err == 0);
-  assert(bufused == strlen(path) + 1);
+  assert(bufused == strlen(path));
   assert(strcmp(buf, path) == 0);
 
   err = uvwasi_path_unlink_file(&uvwasi, 3, linkname, strlen(linkname));
@@ -79,7 +79,7 @@ int main(void) {
                              strlen(truncated_path) + 1,
                              &bufused);
   assert(err == 0);
-  assert(bufused == strlen(truncated_path) + 1);
+  assert(bufused == strlen(truncated_path));
   assert(strcmp(buf, truncated_path) == 0);
 
   err = uvwasi_path_unlink_file(&uvwasi, 3, truncated_linkname, strlen(truncated_linkname));