Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate whatwg websocket logic from rfc 6455 #3396

Merged
merged 5 commits into from
Jul 8, 2024
Merged

separate whatwg websocket logic from rfc 6455 #3396

merged 5 commits into from
Jul 8, 2024

Conversation

KhafraDev
Copy link
Member

@KhafraDev
Copy link
Member Author

KhafraDev commented Jul 7, 2024 •
edited
Loading

There is still a lot of clunkiness to fix.

  • Remove symbols, use private properties
  • Stop passing ws / this around, only pass the handler

@tsctx
Copy link
Member

tsctx commented Jul 7, 2024

This PR is very good, but it might be better to use an internal class and manage all conditions and hooks there.

@KhafraDev
Copy link
Member Author

I agree, we can continue working on it later.

@KhafraDev KhafraDev marked this pull request as ready for review July 7, 2024 19:12
mcollina
mcollina approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rlgtm

@KhafraDev KhafraDev merged commit 7436fee into nodejs:main Jul 8, 2024
31 checks passed
@KhafraDev KhafraDev deleted the separate-whatwg-from-rfc branch July 8, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsctx tsctx tsctx approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KhafraDev @tsctx @mcollina @metcoder95