fixup types and add test

Signed-off-by: flakey5 <[email protected]>
nodejs · Oct 25, 2024 · 19b0eaf · 19b0eaf
1 parent 5a04bcb
commit 19b0eaf
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 6 deletions.
diff --git a/lib/cache/sqlite-cache-store.js b/lib/cache/sqlite-cache-store.js
@@ -128,11 +128,12 @@ class SqliteCacheStore {
     this.#db = new DatabaseSync(opts?.location ?? ':memory:')
 
     /**
+     * @see https://sqlite.org/schematab.html#interpretation_of_the_schema_table
      * @type {{
      *  type: 'table' | 'index' | (string & {}),
      *  name: string,
      *  tbl_name: string,
-     *  sql: number
+     *  sql: string
      * }[]}
      */
     const items = this.#db.prepare(

diff --git a/test/cache-interceptor/cache-stores.js b/test/cache-interceptor/cache-stores.js
@@ -13,6 +13,7 @@ if (
   (env.NODE_OPTIONS && env.NODE_OPTIONS.match(/experimental(-|_)sqlite/)) ||
   execArgv.some(argv => argv.match(/experimental(-|_)sqlite/))
 ) {
+  const { DatabaseSync } = require('node:sqlite')
   const SqliteCacheStore = require('../../lib/cache/sqlite-cache-store.js')
 
   cacheStoreTests(SqliteCacheStore)
@@ -81,6 +82,32 @@ if (
       rawTrailers: requestTrailers
     })
   })
+
+  test('SqliteCacheStore ignores unknown types tied to cacheInterceptor table when sql is right', async (t) => {
+    const sqliteLocation = 'cache-interceptor.sqlite'
+
+    t.after(async () => {
+      await rm(sqliteLocation)
+    })
+
+    // eslint-disable-next-line no-unused-vars
+    const _ = new SqliteCacheStore({
+      location: sqliteLocation
+    })
+
+    const db = new DatabaseSync(sqliteLocation)
+    db.exec('CREATE VIEW cacheInterceptorView AS SELECT * FROM cacheInterceptor')
+
+    // eslint-disable-next-line no-unused-vars
+    const _2 = new SqliteCacheStore({
+      location: sqliteLocation
+    })
+
+    equal(
+      db.prepare('SELECT * FROM sqlite_master WHERE type = \'view\' AND name = \'cacheInterceptorView\'').all().length,
+      1
+    )
+  })
 }
 
 /**

diff --git a/test/types/cache-interceptor.test-d.ts b/test/types/cache-interceptor.test-d.ts
@@ -65,7 +65,6 @@ expectAssignable<CacheInterceptor.MemoryCacheStoreOpts>({
 expectAssignable<CacheInterceptor.SqliteCacheStoreOpts>({})
 expectAssignable<CacheInterceptor.SqliteCacheStoreOpts>({
   location: '',
-  maxEntries: 0,
   maxEntrySize: 0,
   errorCallback: (_: Error) => {}
 })
diff --git a/types/cache-interceptor.d.ts b/types/cache-interceptor.d.ts
@@ -101,10 +101,6 @@ declare namespace CacheHandler {
      * @default ':memory:'
      */
     location?: string
-    /**
-     * @default Infinity
-     */
-    maxEntries?: number
     /**
      * @default Infinity
      */