feat: add post benchmark

nodejs · Mar 2, 2024 · 10b2397 · 10b2397
1 parent 0be1e99
commit 10b2397
Show file tree

Hide file tree

Showing 4 changed files with 477 additions and 11 deletions.
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -49,3 +49,46 @@ jobs:
       - name: Run Benchmark
         run: npm run bench
         working-directory: ./benchmarks
+
+  benchmark_post_current:
+    name: benchmark (post) current
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+          persist-credentials: false
+          ref: ${{ github.base_ref }}
+      - name: Setup Node
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
+        with:
+          node-version: lts/*
+      - name: Install Modules for undici
+        run: npm i --ignore-scripts --omit=dev
+      - name: Install Modules for Benchmarks
+        run: npm i
+        working-directory: ./benchmarks
+      - name: Run Benchmark
+        run: npm run bench-post
+        working-directory: ./benchmarks
+
+  benchmark_post_branch:
+    name: benchmark (post) branch
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+          persist-credentials: false
+      - name: Setup Node
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
+        with:
+          node-version: lts/*
+      - name: Install Modules for undici
+        run: npm i --ignore-scripts --omit=dev
+      - name: Install Modules for Benchmarks
+        run: npm i
+        working-directory: ./benchmarks
+      - name: Run Benchmark
+        run: npm run bench-post
+        working-directory: ./benchmarks
diff --git a/benchmarks/benchmark.js b/benchmarks/benchmark.js
@@ -34,22 +34,16 @@ if (process.env.PORT) {
   dest.socketPath = path.join(os.tmpdir(), 'undici.sock')
 }
 
+/** @type {http.RequestOptions} */
 const httpBaseOptions = {
   protocol: 'http:',
   hostname: 'localhost',
   method: 'GET',
   path: '/',
-  query: {
-    frappucino: 'muffin',
-    goat: 'scone',
-    pond: 'moose',
-    foo: ['bar', 'baz', 'bal'],
-    bool: true,
-    numberKey: 256
-  },
   ...dest
 }
 
+/** @type {http.RequestOptions} */
 const httpNoKeepAliveOptions = {
   ...httpBaseOptions,
   agent: new http.Agent({
@@ -58,6 +52,7 @@ const httpNoKeepAliveOptions = {
   })
 }
 
+/** @type {http.RequestOptions} */
 const httpKeepAliveOptions = {
   ...httpBaseOptions,
   agent: new http.Agent({
@@ -142,7 +137,11 @@ class SimpleRequest {
 }
 
 function makeParallelRequests (cb) {
-  return Promise.all(Array.from(Array(parallelRequests)).map(() => new Promise(cb)))
+  const promises = new Array(parallelRequests)
+  for (let i = 0; i < parallelRequests; ++i) {
+    promises[i] = new Promise(cb)
+  }
+  return Promise.all(promises)
 }
 
 function printResults (results) {
@@ -303,7 +302,7 @@ if (process.env.PORT) {
 
   experiments.got = () => {
     return makeParallelRequests(resolve => {
-      got.get(dest.url, null, { http: gotAgent }).then(res => {
+      got.get(dest.url, { agent: { http: gotAgent } }).then(res => {
         res.pipe(new Writable({
           write (chunk, encoding, callback) {
             callback()

diff --git a/benchmarks/package.json b/benchmarks/package.json
@@ -2,9 +2,12 @@
   "name": "benchmarks",
   "scripts": {
     "bench": "PORT=3042 concurrently -k -s first npm:bench:server npm:bench:run",
+    "bench-post": "PORT=3042 concurrently -k -s first npm:bench:server npm:bench-post:run",
     "bench:server": "node ./server.js",
     "prebench:run": "node ./wait.js",
-    "bench:run": "SAMPLES=100 CONNECTIONS=50 node ./benchmark.js"
+    "bench:run": "SAMPLES=100 CONNECTIONS=50 node ./benchmark.js",
+    "prebench-post:run": "node ./wait.js",
+    "bench-post:run": "SAMPLES=100 CONNECTIONS=50 node ./post-benchmark.js"
   },
   "dependencies": {
     "axios": "^1.6.7",